Author Topic: RaidAchievement leaks global variables  (Read 3803 times)

0 Members and 1 Guest are viewing this topic.

Offline cremor

  • Newbie
  • *
  • Posts: 2
    • View Profile
RaidAchievement leaks global variables
« on: November 18, 2012, 15:05:46 »
RaidAchievement sets a huge amount of global variables, this is a problem if the same variable name is used by another addon or the Blizzard UI. In particular, RaidAchievement sets the global _ (underscore) variable at some points. This is a big problem since a part of the Blizzard UI uses this global underscore variable and breaks if it was set by an addon. Background: http://forums.wowace.com/showthread.php?t=20297

Please use FindGlobals or Wow Global Finder to find these code errors and fix them!

Here are the lines where a global underscore is set:

Code: [Select]
function <C:\Spiele\World of Warcraft\Interface\AddOns\RaidAchievement_CataHeroics\\RaidAchievement_CataHeroics.lua:1,81> (85 instructions, 340 bytes at 0030E570)
[5] SETGLOBAL 0 -4 ; _
function <C:\Spiele\World of Warcraft\Interface\AddOns\RaidAchievement_Naxxramas\\RaidAchievement_Naxxramas.lua:72,232> (326 instructions, 1304 bytes at 003C81A0)
[208] SETGLOBAL 33 -70 ; _
[208] SETGLOBAL 32 -70 ; _
[208] SETGLOBAL 31 -70 ; _
[210] SETGLOBAL 33 -70 ; _
[210] SETGLOBAL 32 -70 ; _
[210] SETGLOBAL 31 -70 ; _
function <C:\Spiele\World of Warcraft\Interface\AddOns\RaidAchievement_PandaHeroics\\RaidAchievement_PandaHeroics.lua:1,63> (72 instructions, 288 bytes at 0061E570)
[4] SETGLOBAL 0 -4 ; _
function <C:\Spiele\World of Warcraft\Interface\AddOns\RaidAchievement_PandaScenarios\\RaidAchievement_PandaScenarios.lua:1,58> (75 instructions, 300 bytes at 006BE518)
[4] SETGLOBAL 0 -4 ; _
function <C:\Spiele\World of Warcraft\Interface\AddOns\RaidAchievement_WotlkHeroics\\RaidAchievement_WotlkHeroics.lua:1,55> (84 instructions, 336 bytes at 0026E570)
[8] SETGLOBAL 0 -9 ; _

Offline Shurshik

  • Administrator
  • Sr. Member
  • *****
  • Posts: 345
    • View Profile
  • Guild: Black Lotus
  • Server: Gordunni
Re: RaidAchievement leaks global variables
« Reply #1 on: November 18, 2012, 16:23:32 »
Thanks, I'll fix it soon, next week, I think.